Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make q, k, and v contiguous to get better performance for normalize #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CaoE
Copy link

@CaoE CaoE commented Aug 22, 2022

Make q, k, and v contiguous to get better performance for normalize.
After the rearrange operations for q, k, and v, normalizations on the last dim for q and k will be applied. The non-contiguous memory format makes the performance of normalize on the last dim poor.

Eslzzyl added a commit to Eslzzyl/Restormer that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant