Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(movies): update to ng17, rxa 17, eslint #280

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

BioPhoton
Copy link
Member

@BioPhoton BioPhoton commented Nov 12, 2023

This PR includes:

  • Nx update v17
  • Angular update to v17
  • RxAngular update to v16.3.0
  • package.json overwrites
  • Refactoring of the state logic to functional style

Possible in a follow up PR:

  • update to new builder
  • bundle budget updates
  • webpage test measures

Copy link

github-actions bot commented Nov 12, 2023

Visit the preview URL for this PR (updated for commit c998cac):

https://angular-movies-a12d3--update-to-ng17-w2uueccr.web.app

(expires Sun, 07 Apr 2024 12:51:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f5e1819659ee450e0b7241d53391169f76c6f1d4

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@eneajaho eneajaho mentioned this pull request Nov 12, 2023
@JeanMeche
Copy link
Collaborator

Can we look to get the v17 migration merged ? :)

@eneajaho eneajaho changed the title refactor(movies): update to ng17, rxa 16.3.0, eslint refactor(movies): update to ng17, rxa 17, eslint Mar 8, 2024
refactor(movies): migrate to use application builder SSR features
@eneajaho
Copy link
Collaborator

eneajaho commented Mar 8, 2024

Icons are not working on Firebase. But they work locally. Probably because of prerendering happening at build time.

@hoebbelsB
Copy link
Collaborator

any updates on this? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants