Docs improvements #2935
Open
Docs improvements #2935
+100
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
reviewed
Sep 19, 2024
…ters Rename the parameters to "item" to match the spec text. Make clear that they can be a string, property bag, or instance, but not other types like number, bigint, etc. Closes: #1394
…endar These types don't exist anymore. Having them in the diagrams suggests that they do. Not sure why the "width:auto;" is necessary after editing object-model.svg but without that, it shows up huge in the HTML page.
These were using removed APIs and so had broken. Because they're interactive, they're not tested in CI.
This example shows how to set properties of an HTML input element using Temporal objects. For discoverability, link to a later example that shows how to do the reverse. See: #1576
It wasn't clear what "these extensions" referred to from the text, and the IETF process is finished now.
ptomato
force-pushed
the
docs-improvements
branch
from
eafbe49
to
f09c3d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
+ Coverage 96.51% 97.29% +0.77%
==========================================
Files 23 22 -1
Lines 12432 10899 -1533
Branches 2258 1849 -409
==========================================
- Hits 11999 10604 -1395
+ Misses 374 295 -79
+ Partials 59 0 -59 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the docs, mostly taken from a sweep of the issue backlog. Also corrected other mistakes I ran into.