Add eye in Recovery Code input, which on press displays wrong password #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Caroline-lawson can you test the usability of the solution on this url : https://tchap-web-staging-v4-pr588.osc-secnum-fr1.scalingo.io/#/login |
|
|
|
It works. It would be better to always show the password when clicked once on the eye, but this is still an improvement. |
odelcroi
approved these changes
May 9, 2023
NicolasBuquet
approved these changes
May 9, 2023
odelcroi
approved these changes
May 9, 2023
|
I agree with @Caroline-lawson . It's not ideal, but it is stil an improvement. |
|
element PR : matrix-org/matrix-react-sdk#10832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. issue #548
and issue #563
Before:
After:
Before:
After: