New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterator function doesn't accept the arguments object. #54

Open

Naddiseo wants to merge 2 commits into termi:master from Naddiseo:spread_arguments

Naddiseo commented Sep 16, 2014

Currently the implementation of the iterator protocol doesn't accept an Arguments object.

Testcase:

function test() {
    console.log(...arguments);
}
test(1, 2, 3); // => should print "1 2 3"

This PR is one solution to the problem. I would have updated the tests, but there are too many to do by hand.

richardasymmetric added 2 commits

September 16, 2014 13:28


          Check for arguments object

1c9d615


          Made argument checking more robust, and fixed slice call

45d6ded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet