Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x11/kf5): Prevent auto-updating to version 6.x.x #21505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Biswa96
Copy link
Member

@Biswa96 Biswa96 commented Sep 18, 2024

%ci:no-build

@Biswa96
Copy link
Member Author

Biswa96 commented Sep 18, 2024

Need reviews who actually knows what happens with version regex in hindsight.

@TomJo2000
Copy link
Member

Need reviews who actually knows what happens with version regex in hindsight.

That check is done here.

# If needed, filter version numbers using grep regexp.
if [[ -n "${TERMUX_PKG_UPDATE_VERSION_REGEXP:-}" ]]; then
# Extract version numbers.
local OLD_LATEST_VERSION="${LATEST_VERSION}"
LATEST_VERSION="$(grep -oP "${TERMUX_PKG_UPDATE_VERSION_REGEXP}" <<< "${LATEST_VERSION}" || true)"
if [[ -z "${LATEST_VERSION:-}" ]]; then
termux_error_exit <<-EndOfError
ERROR: failed to filter version numbers using regexp '${TERMUX_PKG_UPDATE_VERSION_REGEXP}'.
Ensure that it works correctly with ${OLD_LATEST_VERSION}.
EndOfError
fi
unset OLD_LATEST_VERSION
fi

I personally think the variable names are a bit misleading, but the latest version number is compared against the PCRE specified in TERMUX_PKG_UPDATE_VERSION_REGEXP and the autoupdate is only allowed if the regex matches.

@Biswa96
Copy link
Member Author

Biswa96 commented Sep 18, 2024

I do not know if the packages will be updated automatically when there is a newer 5.x.x version.

@TomJo2000
Copy link
Member

Assuming say a 5.117.0 release, yes they would.
As that will match the regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants