Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jsdom #568

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blakenetz
Copy link

@blakenetz blakenetz commented Jan 10, 2024

What:

Upgrade jsdom dep to 23.2.0.

Since this version of the library uses a "logical OR" operator, I also bumped GH runner's node version from 14 to 16.

Why:

This release resolves a bug with the CSS selector engine. More information about this bug can be found in this react-testing-library issue.

More information about how the CSS selector bug was resolved can be found in the [email protected] release notes

How:

Upgraded the dependency.

Checklist:

  • Documentation n/a
  • Tests n/a
  • Updated Type Definitions n/a
  • Ready to be merged

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fb156c) 100.00% compared to head (6a97bc6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          668       668           
  Branches       254       254           
=========================================
  Hits           668       668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fullchee
Copy link

JSDOM v22 drops support for Node 14

while jest-dom still supports Node 14 for the current (v6) version

Can we first create a PR that upgrades to Node v21 which still supports Node 14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants