Refactor to typescript attempt #50

kweeuhree · 2024-09-17T13:27:42Z

Description

This code proposes refactoring our application to TypeScript. These changes will keep the app type safe, scalable and easy to read and to debug.
Some console logs are still in place as the work is still in progress.

Type of Changes

enhancement

Updates

Added types.

Issues

Duplicate items are still being added;
New items are being added on refresh - this affects normalization and duplicate check

Testing Steps / QA Criteria

Ran npm start and navigated to localhost:3000,
Logged in,
Added a new list,
Added unique and duplicate items to a new list,
Shared new list,
Verified that list will be only shared when the list is owned by the user that is currently logged in.

- install types and necessary dependencies; - add TypeScript configuration; - change extention of files to .tsx; - add User and Item types.

…ement

…rn in the input element

… List component; removed temporary console.log from Home component

…n in case userId or userEmail is undefined

…ement is null

deeheber · 2024-09-19T22:14:11Z

src/api/firebase.ts

+	userId: string | null | undefined,
+	userEmail: string | null | undefined,


kweeuhree added 30 commits September 16, 2024 11:59

feat: begin refactoring to TypeScript

ab73f01

- install types and necessary dependencies; - add TypeScript configuration; - change extention of files to .tsx; - add User and Item types.

feat: add ListPath type

f9b3aae

feat: add types to all firebase functions

cf7ad59

fix: change useAuth.jsx component extention to .tsx

def133a

each User type property can be a string and null;add types to useAuth

872d8fc

fix: fix the way useShoppingLists takes props

2082dee

fix: remove User type

c2f3988

fix: remove redundant User type; use DocumentData type where needed

77945a8

add type to ManageList props

2e72f6a

fix: fix type of addItem function parameters

e48619d

feat: add types to AddItems component; pass label prop to TextInputEl…

8d648a2

…ement

feat: add types to TextInputElement component props, as well as patte…

56736ac

…rn in the input element

feat: add type to List component props, pass items to AddItems component

172a520

feat: add types to normalizeItemName utility function

cb2b2a9

feat: add types to App component

568b943

fix: add fixes to AddItems component types

7c2a158

feat: add types to Home component

90bc64d

fix: add fixes to ManageList component type

84845a4

fix: add fixes to List component type

3ad80a5

feat: add types to Layout component

95c0608

feat: add types to useStateWithStorage hook

c0d64d4

fix: change main point of entry from jsx to tsx

1af02b2

feat: add types to ListItem component

4312d46

feat: add types to RadioInputElement component

4b00780

feat: add types to SingleList component

5f0a39d

feat: add types to ShareList component

9705ebd

feat: add types to dates.js module

69d3615

fix: adjust how parameters are being passed into functions

330b2d6

fix: remove redundant file

5fceeb1

fix: update listPath type to be either string or null

26de591

kweeuhree added 4 commits September 16, 2024 19:56

fix: add optional chaining operator to items List component

1a75fda

fix[test]: update List component to take items prop

764ba25

troubleshoot AddItems component

67e1b92

troubleshoot listPath in Home, List and AddItems components

cc87268

kweeuhree self-assigned this Sep 17, 2024

kweeuhree added help wanted Extra attention is needed refactoring labels Sep 17, 2024

kweeuhree added 5 commits September 17, 2024 09:47

fix: fixed listPath issue with passing listPath as a prop from App to…

d57923a

… List component; removed temporary console.log from Home component

fix: add listPath prop to List.test

8c395f0

fix: userId and userEmail can be undefined; update functions to retur…

4117b8e

…n in case userId or userEmail is undefined

fix: add a try/catch block in index.ts to handle a case where root el…

640dae8

…ement is null

fix: handle a case where listPath is null

1ae6c7a

deeheber reviewed Sep 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor to typescript attempt #50

Refactor to typescript attempt #50

kweeuhree commented Sep 17, 2024 •

edited

Loading

deeheber Sep 19, 2024

		userId: string \| null \| undefined,
		userEmail: string \| null \| undefined,

Refactor to typescript attempt #50

Are you sure you want to change the base?

Refactor to typescript attempt #50

Conversation

kweeuhree commented Sep 17, 2024 • edited Loading

Description

Type of Changes

Updates

Issues

Testing Steps / QA Criteria

deeheber Sep 19, 2024

Choose a reason for hiding this comment

kweeuhree commented Sep 17, 2024 •

edited

Loading