Merge pull request #58 from runeharlyk/event-socket-lock

Ensure thread safety for client subscriptions
theelims · Jul 23, 2024 · b5898d6 · b5898d6
2 parents bf812de + 8053c42
commit b5898d6
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/framework/EventSocket.cpp b/lib/framework/EventSocket.cpp
@@ -41,10 +41,12 @@ void EventSocket::onWSOpen(PsychicWebSocketClient *client)
 
 void EventSocket::onWSClose(PsychicWebSocketClient *client)
 {
+    xSemaphoreTake(clientSubscriptionsMutex, portMAX_DELAY);
     for (auto &event_subscriptions : client_subscriptions)
     {
         event_subscriptions.second.remove(client->socket());
     }
+    xSemaphoreGive(clientSubscriptionsMutex);
     ESP_LOGI("EventSocket", "ws[%s][%u] disconnect", client->remoteIP().toString().c_str(), client->socket());
 }