MdePkg/SecurityPkg: Add dev auth boot mode #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenxing-hou
force-pushed
the
add_devAuthBoot_mode
branch
from
bed3de4
to
8171a7c
Compare
Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
add_devAuthBoot_mode
branch
from
8171a7c
to
21045f8
Compare
Wenxing-hou
changed the title
Zhiqiang520
suggested changes
Jan 20, 2024
| FreePool (DeviceAuthBootMode); | ||
| return FALSE; | ||
| } else { | ||
| return TRUE; |
There was a problem hiding this comment.
Here I think we should also call FreePool (DeviceAuthBootMode); before return TRUE;, otherwise it will memory leak.
There was a problem hiding this comment.
Thanks. I have fixed this code.
Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
add_devAuthBoot_mode
branch
from
21045f8
to
811cae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.