[close #396] upgrade log4j and slf4j #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <[email protected]>
github-actions
bot
added
component/common
component/rawkv
component/txnkv
component/cdc
labels
zz-jason
reviewed
Dec 16, 2021
| <log4j.version>1.2.17</log4j.version> | ||
| <slf4j.version>1.7.16</slf4j.version> | ||
| <log4j.version>2.15</log4j.version> | ||
| <slf4j.version>2.0.0-alpha5</slf4j.version> |
There was a problem hiding this comment.
why using the alpha version of log4j?
| @@ -30,6 +30,7 @@ | |||
| import org.tikv.service.failsafe.CircuitBreaker; | |||
|
|
|||
| public class SmartRawKVClient implements RawKVClientBase { | |||
|
|
|||
There was a problem hiding this comment.
Why add this empty line? Is it caused by the formater?
| @@ -63,8 +63,8 @@ | |||
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | |||
| <rocksdb.version>6.22.1.1</rocksdb.version> | |||
| <protobuf.version>3.5.1</protobuf.version> | |||
| <log4j.version>1.2.17</log4j.version> | |||
| <slf4j.version>1.7.16</slf4j.version> | |||
| <log4j.version>2.15</log4j.version> | |||
There was a problem hiding this comment.
should it be 2.15.0?
There was a problem hiding this comment.
It is recommended to upgrade to 2.17.1, which fixes all known vulnerabilities, see: https://logging.apache.org/log4j/2.x/security.html.
| @@ -178,7 +179,7 @@ public void onNext(final ChangeDataEvent event) { | |||
| } | |||
|
|
|||
| private void submitEvent(final CDCEvent event) { | |||
| LOGGER.debug("submit event: {}", event); | |||
| LOGGER.atDebug().log("submit event: {}", event); | |||
There was a problem hiding this comment.
The original code is simpler and the performance is the same.
http://www.slf4j.org/faq.html#logging_performance
|
This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus [email protected]
What problem does this PR solve?
Issue Number: close #396
Problem Description: this pull request upgrade the log4j and slf4j to avoid some security issues and improve the performance while a higher log level is set. In addition, this pull request eliminates the code of log level detections which is really annoying. For now, this pull request only focuses on the DEBUG log, instead of the higher-level logs.
What is changed and how it works?
Use slf4j 2.0's fluent API to eliminate the log level check and use lambda syntax to enable lazy log string evaluation.
Check List for Tests
This PR has been tested by the at least one of the following methods: