Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Commit

Permalink
feat: v2 release (#270)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:

Requires the following versions:
- ESLint v8
- TypeScript ESLint v5

Removed the dependency on `eslint-plugin-rxjs`.
To re-enable the RxJS rules for NgRx Effects, you have to manually install the RxJS ESLint plugin.
Details can be found at https://www.npmjs.com/package/eslint-plugin-rxjs

Rename the rule `use-selector-in-select` to `prefer-selector-in-select`.
This makes the name consistent with the other rules.
  • Loading branch information
timdeschryver committed Nov 23, 2021
1 parent c217358 commit 5391760
Show file tree
Hide file tree
Showing 74 changed files with 2,506 additions and 3,527 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ on:
push:
branches:
- 'main'
- 'beta'
pull_request: {}

jobs:
build_test_release:
strategy:
matrix:
node-version: ${{ fromJSON(github.ref == 'refs/heads/main' && '[16]' || '[12,14,16]') }}
os: ${{ fromJSON(github.ref == 'refs/heads/main' && '["ubuntu-latest"]' || '["ubuntu-latest", "windows-latest"]') }}
node-version: ${{ fromJSON((github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta') && '[16]' || '[12,14,16]') }}
os: ${{ fromJSON((github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta') && '["ubuntu-latest"]' || '["ubuntu-latest", "windows-latest"]') }}
runs-on: ${{ matrix.os }}

steps:
Expand Down Expand Up @@ -39,7 +40,7 @@ jobs:
run: npm run test:cov

- name: 🚀 Release
if: github.repository == 'timdeschryver/eslint-plugin-ngrx' && github.ref == 'refs/heads/main'
if: github.repository == 'timdeschryver/eslint-plugin-ngrx' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta')
run: npx semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
73 changes: 35 additions & 38 deletions README.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Fixable: no
---

# use-selector-in-select
# prefer-selector-in-select

> Using a selector in the `select` is preferred over `string` or `props drilling`.
Expand Down
Loading

0 comments on commit 5391760

Please sign in to comment.