fix: sync preferred select usage (#54)

timdeschryver · Nov 24, 2020 · 8693ec7 · 8693ec7
1 parent 9e23052
commit 8693ec7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/rules/select-style.ts b/src/rules/select-style.ts
@@ -43,7 +43,7 @@ export default ESLintUtils.RuleCreator(docsUrl)<Options, MessageIds>({
         'Selectors should be used with the pipeable operator: this.store.pipe(select(selector))',
     },
   },
-  defaultOptions: [{ mode: OPERATOR }],
+  defaultOptions: [{ mode: METHOD }],
   create: (context, [{ mode }]) => {
     return {
       [pipeableSelect](node: TSESTree.CallExpression) {

diff --git a/tests/rules/store-select.test.ts b/tests/rules/store-select.test.ts
@@ -11,7 +11,7 @@ import { ruleTester } from '../utils'
 
 ruleTester().run(ruleName, rule, {
   valid: [
-    `this.store.pipe(select(selector));`,
+    `this.store.select(selector);`,
     {
       code: `this.store.pipe(select(selector));`,
       options: [{ mode: OPERATOR }],
@@ -24,8 +24,8 @@ ruleTester().run(ruleName, rule, {
   invalid: [
     fromFixture(
       stripIndent`
-        this.store.select(selector);
-        ~~~~~~~~~~~~~~~~~~~~~~~~~~~         [${operatorSelectMessageId}]
+        this.store.pipe(select(selector));
+                        ~~~~~~~~~~~~~~~~   [${methodSelectMessageId}]
       `,
     ),
     fromFixture(
@@ -40,7 +40,7 @@ ruleTester().run(ruleName, rule, {
     fromFixture(
       stripIndent`
         this.store.select(selector);
-        ~~~~~~~~~~~~~~~~~~~~~~~~~~~         [${operatorSelectMessageId}]
+        ~~~~~~~~~~~~~~~~~~~~~~~~~~~       [${operatorSelectMessageId}]
       `,
       {
         options: [{ mode: OPERATOR }],