Remove github.com/packethost/xff dependency #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
changed the title
jacobweinstock
added
the
do-not-merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
====================================
- Coverage 69% 65% -4%
====================================
Files 16 19 +3
Lines 1392 1535 +143
====================================
+ Hits 962 1003 +41
- Misses 403 503 +100
- Partials 27 29 +2 ☔ View full report in Codecov by Sentry. |
jacobweinstock
force-pushed
the
remove-dep-packethost
branch
from
733ee72
to
011961a
Compare
Also, add license header for code copied from the no longer maintainer github.com/equinix-labs/otel-init-go repo. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
remove-dep-packethost
branch
from
011961a
to
ea8a699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also, add license header for code copied from the no longer maintainer github.com/equinix-labs/otel-init-go repo.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: