Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong date format #286

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix wrong date format #286

wants to merge 11 commits into from

Conversation

Miaoyww
Copy link
Contributor

@Miaoyww Miaoyww commented Aug 8, 2024

@Miaoyww
Copy link
Contributor Author

Miaoyww commented Aug 8, 2024

by the way, at CommandTimerPlugin in 101, if the taskManager is null, it will throw a exception.
so i made a check to avoid it

titivermeesch
titivermeesch requested changes Aug 8, 2024
View reviewed changes
src/main/java/me/playbosswar/com/utils/gson/GsonDate.java Outdated Show resolved Hide resolved
src/main/java/me/playbosswar/com/CommandTimerPlugin.java Outdated Show resolved Hide resolved
src/main/java/me/playbosswar/com/CommandTimerPlugin.java Outdated Show resolved Hide resolved
src/main/java/me/playbosswar/com/utils/gson/GsonDate.java Outdated Show resolved Hide resolved
java8-build.gradle Show resolved Hide resolved
Miaoyww
Miaoyww commented Aug 8, 2024
View reviewed changes
Copy link
Contributor Author

@Miaoyww Miaoyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Miaoyww
Copy link
Contributor Author

Miaoyww commented Aug 9, 2024

while i finally noticed that if there is a timer that can not be loaded, it will disable the whole plugin.
however, it is not excepted to happen.

i made a few try catch parts to avoid this problem.

@titivermeesch
Copy link
Owner

@Miaoyww Sorry for the long waiting here. Could you update the version again accordingly? I'll merge it after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titivermeesch titivermeesch titivermeesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miaoyww @titivermeesch