Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP attempt to get serial and RS485 Modbus-RTU working #35

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

iconnor
Copy link
Contributor

@iconnor iconnor commented Jul 21, 2021

Testing on a Acrel acr10r-d16te but it is not working yet so please don't merge.

@pep8speaks
Copy link

pep8speaks commented Jul 21, 2021

Hello @iconnor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 18:121: E501 line too long (151 > 120 characters)
Line 130:121: E501 line too long (130 > 120 characters)

Comment last updated at 2021-08-16 03:56:14 UTC

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #35 (6e20a9a) into master (96da28f) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   95.83%   96.03%   +0.19%     
==========================================
  Files           6        6              
  Lines         841      857      +16     
==========================================
+ Hits          806      823      +17     
+ Misses         35       34       -1     
Impacted Files Coverage Δ
modbus4mqtt/modbus4mqtt.py 94.50% <100.00%> (ø)
modbus4mqtt/modbus_interface.py 96.58% <100.00%> (+1.00%) ⬆️
tests/test_modbus.py 97.32% <100.00%> (+2.46%) ⬆️
tests/test_mqtt.py 97.40% <0.00%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96da28f...6e20a9a. Read the comment docs.

@iconnor
Copy link
Contributor Author

iconnor commented Jul 22, 2021

Still WIP: I am waiting for Acrel to give me the registry map, but if I get an ABB one first, I will post it in the PR

@iconnor
Copy link
Contributor Author

iconnor commented Aug 16, 2021

I have the manual but the values are not changing despite energy flow: https://swordandstone-my.sharepoint.com/:b:/g/personal/ianconnor_swordandstone_com_au/ETclJIj1jX1GreQjrtyl88YBzintfvcHlodOC6UyEoOODg?e=eFKsUB so still have some work on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants