-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP attempt to get serial and RS485 Modbus-RTU working #35
base: master
Are you sure you want to change the base?
Conversation
Hello @iconnor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-08-16 03:56:14 UTC |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 95.83% 96.03% +0.19%
==========================================
Files 6 6
Lines 841 857 +16
==========================================
+ Hits 806 823 +17
+ Misses 35 34 -1
Continue to review full report at Codecov.
|
Still WIP: I am waiting for Acrel to give me the registry map, but if I get an ABB one first, I will post it in the PR |
I have the manual but the values are not changing despite energy flow: https://swordandstone-my.sharepoint.com/:b:/g/personal/ianconnor_swordandstone_com_au/ETclJIj1jX1GreQjrtyl88YBzintfvcHlodOC6UyEoOODg?e=eFKsUB so still have some work on this one. |
Testing on a Acrel acr10r-d16te but it is not working yet so please don't merge.