fix(snowflake): Manually escape single quotes in colon operator #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4090
Snowflake allows JSON extraction through the colon operator such as
col:ab, and double quotes (col:"ab") can optionally be used to include special characters in the key.This will be roundtripped/transpiled to a string literal in the respective function such as
GET_PATH(..., 'ab')which can break queries if single quotes are in the json key.For this reason, this PR escapes those paths at parse time in
_parse_colon_as_variant_extract(). Note that Databricks uses backticks for special characters so it won't be affected.