Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(inline): range sync #8368

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

refactor(inline): range sync #8368

wants to merge 21 commits into from

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented Sep 15, 2024

Close BS-1332

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 3:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 3:27pm

Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: d4eec4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 15, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Sep 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d4eec4a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Sep 15, 2024

size-limit report 📦

Path Size
@blocksuite/blocks 208.44 KB (-0.03% 🔽)
@blocksuite/blocks/schemas 717 B (0%)
@blocksuite/blocks/effects 283.02 KB (-0.05% 🔽)
@blocksuite/block-std 22.7 KB (-1.12% 🔽)
@blocksuite/block-std/gfx 10.88 KB (0%)
@blocksuite/block-std/effects 3.86 KB (0%)
@blocksuite/global 13 B (0%)
@blocksuite/global/utils 11.11 KB (0%)
@blocksuite/global/env 231 B (0%)
@blocksuite/global/exceptions 552 B (0%)
@blocksuite/global/di 1.65 KB (0%)
@blocksuite/inline 8.67 KB (+3.24% 🔺)
@blocksuite/inline/consts 51 B (0%)
@blocksuite/inline/effects 1.73 KB (+28.7% 🔺)
@blocksuite/inline/types 13 B (0%)
@blocksuite/store 16.09 KB (0%)
@blocksuite/presets 21.45 KB (0%)
@blocksuite/presets/effects 34.2 KB (0%)
@blocksuite/presets/themes/* 136 B (0%)

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering are there some RFCs or descriptions about the refactoring?

@Flrande
Copy link
Member Author

Flrande commented Sep 18, 2024

Wondering are there some RFCs or descriptions about the refactoring?

No, because this PR did not cause many API changes; it mainly focuses on optimizing the existing code.

Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for resolving IME issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants