clippy fixes #6789
Open
clippy fixes #6789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-current-thread
barafael
commented
Aug 17, 2024
| @@ -1094,7 +1094,7 @@ impl<T> From<T> for RwLock<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: ?Sized> Default for RwLock<T> | |||
| impl<T> Default for RwLock<T> | |||
There was a problem hiding this comment.
Default requires Sized, so the ?Sized makes no difference
barafael
force-pushed
the
rb/clippy_fixes
branch
3 times, most recently
from
89f6bba
to
50c5ae5
Compare
barafael
force-pushed
the
rb/clippy_fixes
branch
from
50c5ae5
to
f1ac63d
Compare
let-else, ?, assert, and expect
barafael
force-pushed
the
rb/clippy_fixes
branch
from
f1ac63d
to
682bea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bunch of selected warnings produced by clippy. I organized the commits by lint group, so if one lint is not favored, we can hopefully just skip that commit.