Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: stabilize Id #6793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

task: stabilize Id #6793

wants to merge 1 commit into from

Conversation

evanrittenhouse
Copy link
Contributor

Motivation

Graduate task::Id to the stable API. Per Discord, there aren't any blockers to doing so.

Solution

@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels Aug 18, 2024
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-task Module: tokio/task labels Aug 19, 2024
@Darksonn
Copy link
Contributor

Can we remove the cfg(tokio_unstable) at the top of the file containing tests?

I believe there are a few more methods that we can stabilize: JoinHandle::id and AbortHandle::id. There is also JoinSet::join_next_with_id, which I am less certain about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-task Module: tokio/task R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanrittenhouse @Darksonn