-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n new LWC (AR+EG) #958
base: main
Are you sure you want to change the base?
i18n new LWC (AR+EG) #958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a space after colon for the better readability and grammatically correct (maybe we can use nbsp). Rest, it looks good.
<lightning-card title="MiscI18n" icon-name="custom:custom19"> | ||
<div class="slds-var-m-around_medium"> | ||
<p> | ||
User's locale: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after colon for the better readability and grammatically correct (maybe we can use nbsp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Satya for your review, I will add the spaces and let you know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made, please let me know.
<span class="userLocale"><b>{userLocale}</b></span> | ||
</p> | ||
<p> | ||
Today's date formatted with {userLocale}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after colon for the better readability
</span> | ||
</p> | ||
<p> | ||
100 {userCurrency} formatted with {userLocale}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after colon for the better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space can be included in html using
</span> | ||
</p> | ||
<p> | ||
Today's date formatted with {japanLocale}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after colon for the better readability
</span> | ||
</p> | ||
<p> | ||
100 {japanCurrency} formatted with {japanLocale}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after colon for the better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please use
instead of space as HTML collapses whitespaces by default. Same for other spaces as well.
Hi Satya, changes done, after replacing spaces after colon with |
What does this PR do?
Add localization recipe
What issues does this PR fix or reference?
#
The PR fulfills these requirements:
[ ] Tests for the proposed changes have been added/updated.
[ ] Code linting and formatting was performed.
Functionality Before
<insert gif and/or summary>
Functionality After
<insert gif and/or summary>