Conversion from tileKey into extendedSpatialID #27
Conversation
…lIDs especially altitude conversion between AltitudeKeys and VerticalFIndex
in ConvertQuadkeysAndAltitudekeysToExtendedSpatialIDs
…for documentation
mi-24v
added
documentation
| extendedSpatialID.SetY(int64(mapTile.Y)) | ||
| extendedSpatialID.SetZ(z) | ||
| extendedSpatialID.SetZoom(r.QuadkeyZoom(), r.AltitudekeyZoom()) | ||
| extendedSpatialIDs = append(extendedSpatialIDs, *extendedSpatialID) |
There was a problem hiding this comment.
ConvertExtendedSpatialIDsToQuadkeysAndVerticalIDs(_) returns a unique slice.
For the consistency, make extendedSpatialIDs unique.
| // } | ||
| // | ||
| // extendedSpatialIDs :["20/85263/65423/23/-2", "20/85263/65423/23/-1"] | ||
| func ConvertQuadkeysAndAltitudekeysToExtendedSpatialIDs(request []*object.FromExtendedSpatialIDToQuadkeyAndAltitudekey) ([]object.ExtendedSpatialID, error) { |
There was a problem hiding this comment.
This is a parallel function of ConvertQuadkeysAndVerticalIDsToExtendedSpatialIDs(_).
So the parameters should be similar.
However, outputHZoom and outputVZoom are missing.
Also, QuadkeyAndAltitudekey should be used instead of FromExtendedSpatialIDToQuadkeyAndAltitudekey.
Execute extendedSpatialIDCheckZoom(_) and quadkeyCheckZoom(_).
Please fix this.
| return extendedSpatialIDs, nil | ||
| } | ||
|
|
||
| func convertAltitudeKeyToZ(altitudekey int64, altitudekeyZoomLevel int64, zZoomLevel int64, zBaseExponent int64, zBaseOffset int64) (int64, int64, error) { |
There was a problem hiding this comment.
We decided to make these converters public.
Make convertAltitudeKeyToZ(_) and convertZToAltitudeKey(_) public.
There was a problem hiding this comment.
Why do you change all of this?
There was a problem hiding this comment.
It seems to be CRLF -> LF conversion was made in e5825d39
using ignore whitespace will suppress too many diff
need fix?
…ConvertTileXYZToExtendedSpatialIDs()` not to using Quadkey
|
it founds that QuadkeysAndAltitudekeys should not be used in new feature (#28 ) |
feature
ConvertQuadkeysAndAltitudekeysToExtendedSpatialIDsConvertQuadkeysAndAltitudekeysToExtendedSpatialIDs