Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poling translations infinite loop fix #200

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

foteinigk
Copy link
Contributor

@foteinigk foteinigk commented Jul 31, 2023

If downloading translations fails due to reasons such as the inability to create the downloaded file the "redirect" field in the response is empty, an infinite loop can occur. To avoid this we can break the loop if task's status is failed

If downloading translations fails due
to reasons such as the inability to
create the downloaded file
the  "redirect" field in the
response is empty and status is falied
Based on backoff functionality, a request will be retried after
1s, 1s, 1s, 2s, 3s, 5s, 8s, 13s and then after 13s forever
To avoid this we can break the loop if status of task is failed

Remove retries
@foteinigk foteinigk force-pushed the TX-14801_pull_requests_loop branch from fd077f8 to 2e68793 Compare July 31, 2023 10:58
Copy link

@manos-transifex manos-transifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one 👍

@foteinigk foteinigk merged commit ee2462a into devel Jul 31, 2023
6 checks passed
@foteinigk foteinigk deleted the TX-14801_pull_requests_loop branch July 31, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants