Make language mappings deterministic #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbairak
force-pushed
the
TX-15697-fix_language_mappings
branch
from
21ee013
to
c4430f8
Compare
Consider this scenario: Someone has in their config file:
```ini
[main]
lang_map = it: it-IT
[RESOURCE_ID]
lang_map = it: it_IT
```
Before we created a local-to-remote map that looked like this:
```json
{"it-IT": "it", "it_IT", "it"}
```
And then, to create the remote-to-local map, we reversed it. The problem
was that, since both values are the same, the key that ended up being
selected was random, so it could either be:
```json
{"it": "it-IT"}
```
or
```json
{"it": "it_IT"}
```
To fix the issue, we now create remote-to-local first, going over the
global configuration first and the resource-level configuration second
so that the resource-level will prevail and thus take preference, and
then we create the local-to-remote by reversing. So,
First, we will consume the global configuration:
```json
{"it": "it-IT"}
```
Then, as the resource-level configuration is consumed, it will replace
the old key:
```json
{"it": "it_IT"}
```
And then, the local-to-remote will end up being:
```json
{"it_IT": "it"}
```
This is the deterministic and the intended behaviour, since
resource-level configuration should take precedence.
kbairak
force-pushed
the
TX-15697-fix_language_mappings
branch
from
c4430f8
to
847d44a
Compare
foteinigk
reviewed
Sep 4, 2024
foteinigk
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this scenario: Someone has in their config file:
Before we created a local-to-remote map that looked like this:
{"it-IT": "it", "it_IT", "it"}And then, to create the remote-to-local map, we reversed it. The problem was that, since both values are the same, the key that ended up being selected was random, so it could either be:
{"it": "it-IT"}or
{"it": "it_IT"}To fix the issue, we now create remote-to-local first, going over the global configuration first and the resource-level configuration second so that the resource-level will prevail and thus take preference, and then we create the local-to-remote by reversing. So,
First, we will consume the global configuration:
{"it": "it-IT"}Then, as the resource-level configuration is consumed, it will replace the old key:
{"it": "it_IT"}And then, the local-to-remote will end up being:
{"it_IT": "it"}This is the deterministic and the intended behaviour, since resource-level configuration should take precedence.