Remove defaultProps from React package #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 18.3 added a deprecation warning for usage of defaultProps in functional components.
|
Would love to see this merged for the same reasons 💯 |
|
Is anybody looking at this? I imagine there's quite a few people interested in this getting merged |
|
@lborba Thank you for your contribution. We really appreciate it. Would it be possible to do the following before we can merge this PR? Sign the CLA as explained in the CONTRIBUTING.md . (This is only required once) |
|
@nbasili CLA sent. |
n1k0sv
approved these changes
Jun 7, 2024
|
@lborba Thanks a lot! Patch released on npm as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 18.3 added a deprecation warning for usage of defaultProps in functional components.
This PR replaces its usage with Javascript's default parameters.