Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config package know about FT proofs #23

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Aug 31, 2023

This PR is a step towards having the applet handle OS and applet updates.

It:

  • adds a place to store firmware transparency info relating to the firmware image the config struct points to
  • removes imx6ul specific deps from the config package, allowing it to be imported by the applet.

See transparency-dev/armored-witness-applet#98 and transparency-dev/armored-witness-os#47.

@AlCutter AlCutter force-pushed the update_impl branch 2 times, most recently from 0a39323 to 75976e5 Compare August 31, 2023 17:04
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that linter hasn't complained about the public fields of the structs not having comments. Maybe add some. Otherwise LGTM.

@AlCutter AlCutter merged commit e2e16c7 into transparency-dev:main Sep 4, 2023
2 checks passed
@AlCutter AlCutter deleted the update_impl branch September 4, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants