Drop dep on the certificate-transparency-go repo #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 82.57% 76.47% -6.11%
==========================================
Files 5 6 +1
Lines 241 323 +82
==========================================
+ Hits 199 247 +48
- Misses 30 45 +15
- Partials 12 31 +19 ☔ View full report in Codecov by Sentry. |
mhutchinson
approved these changes
May 29, 2024
|
@mhutchinson need a re-approval as I had to rebase and resolve |
mhutchinson
approved these changes
Jun 10, 2024
note/note_rfc6962.go
Outdated
| @@ -29,7 +29,8 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| ct "github.com/google/certificate-transparency-go" | |||
| //"github.com/google/certificate-transparency-go/tls" | |||
There was a problem hiding this comment.
Is this comment serving any value?
There was a problem hiding this comment.
gah, will need another re-approve.
mhutchinson
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the temporary dep on the certificate-transparency-go repo by implementing serialisation of STH signature preimages locally.
Fises #105