Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization update #44

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Standardization update #44

merged 5 commits into from
Mar 11, 2024

Conversation

ObserverOfTime
Copy link
Member

This PR updates the repository to use the new bindings and standard workflows.

I need you to do two things for automated package publishing, if you don't mind:

  1. Deprecate your node package (will be published in the org scope):
npm deprecate "@muniftanjim/tree-sitter-lua@*" "Replaced with @tree-sitter-grammars/tree-sitter-lua" 
  1. Add the org team as an owner to the rust package:
cargo owner --add "github:tree-sitter-grammars:crates"

@clason
Copy link
Collaborator

clason commented Mar 10, 2024

@MunifTanjim

@MunifTanjim
Copy link
Collaborator

Got this:

❯ cargo owner --add "github:tree-sitter-grammars:crates"
    Updating crates.io index
error: failed to invite owners to crate `tree-sitter-lua` on registry at https://crates.io

Caused by:
  the remote server responded with an error (status 400 Bad Request): could not find the github team tree-sitter-grammars/crates

@ObserverOfTime

@ObserverOfTime
Copy link
Member Author

I think that's rust-lang/cargo#11505.
See if the proposed solution works.

@MunifTanjim
Copy link
Collaborator

Not sure how to follow that. Don't think I have permissions to do those for this org.

@ObserverOfTime
Copy link
Member Author

It's already set up for the org. You should set it up on your own account.

@MunifTanjim
Copy link
Collaborator

It still doesn't work. Getting the same error.

I've removed crates.io from my github account and connected again (as suggested in that issue). Not sure how that would help in this situation tho. I can't see any teams under https://github.com/tree-sitter-grammars org.

@clason
Copy link
Collaborator

clason commented Mar 11, 2024

The teams are secret (for some reason). @ObserverOfTime is that intended?

@clason
Copy link
Collaborator

clason commented Mar 11, 2024

@MunifTanjim I set it to "visible" -- can you try again? (Sorry about the mess.)

@ObserverOfTime
Copy link
Member Author

Does it work now that it's visible? If not, add me as an owner and I'll handle it. (You can remove me afterwards.)

@MunifTanjim
Copy link
Collaborator

Still doesn't work. What's your username for crates.io?

@MunifTanjim
Copy link
Collaborator

I set it to "visible"

image

I still can't see the "Teams" tab on https://github.com/orgs/tree-sitter-grammars.

It would look like this when I have access to see teams:

image

@clason
Copy link
Collaborator

clason commented Mar 11, 2024

Guess you need to be an organization member then. Sorry!

@ObserverOfTime
Copy link
Member Author

Still doesn't work. What's your username for crates.io?

It's the same as here. That's how crates works.

@clason
Copy link
Collaborator

clason commented Mar 11, 2024

I added you to the team (and org).

@ObserverOfTime
Copy link
Member Author

That's another solution.

@MunifTanjim
Copy link
Collaborator

It worked 🙌🏼

@MunifTanjim
Copy link
Collaborator

I'll deprecate the npm package once the new package is published.

@ObserverOfTime
Copy link
Member Author

Time to merge, tag, and pray.

@ObserverOfTime ObserverOfTime merged commit a24dab1 into main Mar 11, 2024
4 checks passed
@ObserverOfTime ObserverOfTime deleted the update branch March 11, 2024 09:40
@ObserverOfTime
Copy link
Member Author

The packages have been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants