-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic host check #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey the check by itself is great!
For development this will be very useful, we may still need to discuss if want to mix real checks with fake checks.
So code wise LGTM, let's hear what the rest thinks about including it or not :D
aae3a26
to
4677582
Compare
4677582
to
a777c31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the understanding I have about the check yaml, this looks good to me Nelson...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not mix fake and real checks.
I promise I will delete it as soon as we have a real host check. Think of it as as a basic noop or something like that 😅 |
I'm with @dottorblaster on this. |
Yes, we'll have the coming soon communication. Nevertheless before adding the coming soon, we'll deliver a working feature that might be interesting testing. If we don't like this I can ditch it. It will be just a bit more cumbersome testing host checks without the support of an engineer. No hard feelings 😄 |
For demo purposes.