Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VOLUME mount to both dockerfile and sles dockerfile #504

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add VOLUME mount to both dockerfile and sles dockerfile #504

merged 1 commit into from
Sep 4, 2024

Conversation

dottorblaster
Copy link
Contributor

Just adding the VOLUME mount for checks otherwise mounting /usr/share/trento/checks won't work

@dottorblaster dottorblaster self-assigned this Sep 3, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 97.758%. remained the same
when pulling 1782c8a on add-volume-mount
into 3d7df15 on main.

janvhs
janvhs approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@janvhs janvhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow TIL that you can do that in Containerfiles 👀

@dottorblaster dottorblaster merged commit 4bfac87 into main Sep 4, 2024
14 checks passed
@dottorblaster dottorblaster deleted the add-volume-mount branch September 4, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvhs janvhs janvhs approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees

@dottorblaster dottorblaster

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dottorblaster @coveralls @janvhs