-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coinmarket): switch off coinjoin #14338
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I can't see how it looks like, but it makes sense and all the code changes look like it will simply be gone 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise LGTM, does what it's supposed to, just one comment 🚀
Btw you can still sell & swap from existing coinjoin accounts. I assume we don't want to remove that? Just checking.
EDIT: removed.
.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the modal bugfix here
Description
Disable coinjoin account in the trade section when trying to buy/exchange BTC. Also if a coinjoin account is already active, it will not be visible in the select list of discovered accounts.
Related Issue
Resolve #14303