[bug] - Improve seekability check for stdout pipes in BufferedReadSeeker #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
reviewed
Aug 7, 2024
ahrav
force-pushed
the
bug-archives-from-pipe
branch
from
2617930
to
642e0ed
Compare
Removed. Will add to a separate PR. |
Added here |
mcastorina
reviewed
Aug 14, 2024
Comment on lines
+37
to
+38
| seeker io.Seeker // If the reader supports seeking, it's stored here for direct access | ||
| isSeekable bool // Indicates if the reader supports reliable seeking operations |
There was a problem hiding this comment.
Is it possible to remove isSeekable in favor of checking seeker != nil?
pkg/iobuf/bufferedreaderseeker.go
Outdated
Comment on lines
82
to
84
| if isSeekable(r) { | ||
| seeker, _ = r.(io.Seeker) | ||
| seekable = true |
There was a problem hiding this comment.
Since it's only used here, I'd suggest changing isSeekable to:
func asSeeker(r io.Reader) io.Seeker { /* ... */ }and using it like:
if s := asSeeker(r); s != nil {
seeker = s
} else {
buf = defaultBufferPool.Get()
}or maybe
seeker = asSeeker(r)
if seeker == nil {
buf = defaultBufferPool.Get()
}
mcastorina
reviewed
Sep 18, 2024
Comment on lines
85
to
87
| seeker = asSeeker(r) | ||
| if seeker == nil { | ||
| isSeekable = true |
There was a problem hiding this comment.
isSeekable should be set to false, correct? But what do you think about removing isSeekable altogether in favor of seeker != nil checks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When handling files over stdout.Pipe, our current method of checking if a reader is seekable using a simple interface assertion is insufficient. The underlying type of the response from stdout.Pipe is an os.File, which typically implements the io.Seeker interface. However, in this case, it cannot be treated like a regular file and doesn't support seeking operations.
Checklist:
make test-community)?make lintthis requires golangci-lint)?