Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument GitHub source with a ChunkReporter #3296

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Instrument GitHub source with a ChunkReporter #3296

merged 1 commit into from
Sep 16, 2024

Conversation

mcastorina
Copy link
Collaborator

Description:

Replaces all chan *Chunk parameters with a ChunkReporter.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@mcastorina mcastorina requested a review from a team as a code owner September 13, 2024 19:04
@mcastorina mcastorina mentioned this pull request Sep 14, 2024
Open
2 tasks
rosecodym
rosecodym approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this is part of a PR stack?

@mcastorina
Copy link
Collaborator Author

I presume this is part of a PR stack?

Yep! Building up to #3298 (still wip)

@mcastorina mcastorina merged commit 401bc46 into main Sep 16, 2024
12 checks passed
@mcastorina mcastorina deleted the github-scan-reporter branch September 16, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosecodym rosecodym rosecodym approved these changes

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcastorina @rosecodym @ahrav