Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user agent suffix feature flag #3297

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add user agent suffix feature flag #3297

merged 2 commits into from
Sep 13, 2024
+55 −15

Conversation

dustin-decker
Copy link
Contributor

@dustin-decker dustin-decker commented Sep 13, 2024 •
edited
Loading

Description:

Allows specifying a user agent suffix

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@dustin-decker dustin-decker requested review from a team as code owners September 13, 2024 20:25
mcastorina
mcastorina approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like the AtomicString struct to maintain consistency with our other feature flags.

pkg/common/http.go Outdated Show resolved Hide resolved
@dustin-decker dustin-decker merged commit 7e78ca3 into main Sep 13, 2024
11 checks passed
@blsaccess blsaccess mentioned this pull request Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dustin-decker @mcastorina