max 900 bytes #21
Draft
max 900 bytes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlantwood
reviewed
Mar 1, 2022
harlantwood
reviewed
Mar 1, 2022
harlantwood
reviewed
Mar 1, 2022
harlantwood
reviewed
Mar 1, 2022
harlantwood
reviewed
Apr 9, 2023
| @@ -32,7 +32,8 @@ const LINK_TAG_ARROW_REVERSE: [u8; 3] = [226, 134, 169]; // Unicode "↩" // hex | |||
| #[hdk_entry(id = "extra", visibility = "public")] | |||
| #[derive(Clone)] | |||
| pub struct Extra { | |||
| pub fields: BTreeMap<String, String>, // extra content | |||
| pub content_overflow: Option<String>, | |||
There was a problem hiding this comment.
Suggested change
| pub content_overflow: Option<String>, | |
| pub full_content: Option<String>, |
harlantwood
reviewed
Apr 9, 2023
| @@ -32,7 +32,8 @@ const LINK_TAG_ARROW_REVERSE: [u8; 3] = [226, 134, 169]; // Unicode "↩" // hex | |||
| #[hdk_entry(id = "extra", visibility = "public")] | |||
| #[derive(Clone)] | |||
| pub struct Extra { | |||
| pub fields: BTreeMap<String, String>, // extra content | |||
| pub content_overflow: Option<String>, | |||
| pub extra_fields: Option<BTreeMap<String, String>>, // extra content | |||
There was a problem hiding this comment.
would just be empty if nothing in there:
Suggested change
| pub extra_fields: Option<BTreeMap<String, String>>, // extra content | |
| pub extra_fields: BTreeMap<String, String>, // extra content |
harlantwood
reviewed
Apr 9, 2023
| @@ -413,7 +413,8 @@ pub async fn test_get_extra() { | |||
| .await; | |||
There was a problem hiding this comment.
let's have a test that pushes in 1000 bytes of content, and:
- ensure that we get an extra hash in the link tag
- retrieve the content from the extra entry and validate that it is correct
|
@dauphin3 made some comments |
- Modify `Extra` struct to include `content_overflow` and optional `extra_fields` - Update `create` function to handle content overflow - Refactor `create_extra` to accommodate new `Extra` structure - Adjust `create_link_tag` to truncate long content and handle new chunk structure - Update query functions to use new link tag format - Modify tests to reflect changes in `Extra` struct Co-authored-by: Zeek <[email protected]>
Co-authored-by: Zeek <[email protected]>
harlantwood
force-pushed
the
feature/bytes-overflow
branch
from
d50eb15
to
f7944e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7