json feature makes sense only when used with cli feature

It therefore also implies --all-features
tshepang · Oct 4, 2023 · 0864251 · 0864251
1 parent 9f453fc
commit 0864251
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,18 +29,15 @@ jobs:
       with:
           toolchain: ${{ matrix.rust }}
 
+    - name: Build (with no features)
+      run: cargo build --no-default-features
+
     - name: Build
       run: cargo build
 
     - name: Build (with "json" feature)
       run: cargo build --features json
 
-    - name: Build (with all features)
-      run: cargo build --all-features
-
-    - name: Build (with no features)
-      run: cargo build --no-default-features
-
   security-audit:
     runs-on: ubuntu-latest
     steps:

diff --git a/Cargo.toml b/Cargo.toml
@@ -17,7 +17,7 @@ required-features = ["cli"]
 [features]
 default = ["cli"]
 cli = ["dep:clap", "dep:ansi_term", "dep:anyhow"]
-json = ["dep:serde_json", "dep:serde"]
+json = ["dep:serde_json", "dep:serde", "cli"]
 
 [dependencies]
 dirs-next = "2"