Fix go directive version in go.mod #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://go.dev/issues/62278 a concrete go version has to include the patch number or an additional toolchain directive. The project declares the version as 1.21 which is invalid and will result in an error: GOTOOLCHAIN="go1.20+auto" go1.21.5 mod tidy go: downloading go1.21 (linux/amd64) go: download go1.21 for linux/amd64: toolchain not available Changed to 1.21.0 as this is the first actual release of go 1.21.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 70.89% 72.79% +1.89%
==========================================
Files 55 54 -1
Lines 8809 9655 +846
==========================================
+ Hits 6245 7028 +783
- Misses 1675 1732 +57
- Partials 889 895 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://go.dev/issues/62278 a concrete go version has to include the patch number or an additional toolchain directive. The project declares the version as 1.21 which is invalid and will result in an error:
Changed to 1.21.0 as this is the first actual release of go 1.21.