Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in jsdocs #268

Merged
merged 1 commit into from
Oct 11, 2022
Merged

docs: fix typos in jsdocs #268

merged 1 commit into from
Oct 11, 2022

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Oct 9, 2022

Signed-off-by: Seth Falco [email protected]

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

Sorry, another minor JSDoc change! I assume both of those are meant to say "relations".

Ran into this while working on:


I didn't change anything now, but on the side, I think noting that arguments are optional in the JSDocs is redundant. We can see that from the typings already. 🤔

Any thoughts on removing that?

Signed-off-by: Seth Falco <[email protected]>
Copy link
Owner

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@turt2live turt2live merged commit 65462f3 into turt2live:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants