Allow ignoring SELECT from client #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 would really like to see this merged, this prevents us from using twemproxy i.c.m. with Magento sessions. |
|
|
TysonAndre
reviewed
Jun 16, 2021
| @@ -2695,7 +2704,11 @@ redis_reply(struct msg *r) | |||
| switch (r->type) { | |||
| case MSG_REQ_REDIS_PING: | |||
| return msg_append(response, rsp_pong.data, rsp_pong.len); | |||
|
|
|||
| case MSG_REQ_REDIS_SELECT: | |||
There was a problem hiding this comment.
Alternately or additionally, it may be safe to allow forwarding this entirely if the db number is equivalent to the one in the config file for redis_db (pool->redis_db)
rosmo
force-pushed
the
ignore-select-command
branch
from
ca72140
to
3b00524
Compare
…s SELECT commands and always replies with OK.
rosmo
force-pushed
the
ignore-select-command
branch
from
3b00524
to
84c3c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if you are just using database 0, some developers want to call Redis' SELECT command always up front. This add a new redis_ignore_select option to pools to simply return OK for any SELECT command.