This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Localize death messages #844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool 😄 Looking forward to merging this |
|
GG @Pablete1234 you are a boss hahaa |
|
Item names should be translated with translate components https://www.spigotmc.org/wiki/the-chat-component-api/#client-side-translations |
|
@iEli2tyree011 do you know any way of getting "tile.stone.stone.name" from the block? |
|
@twizmwazin add the WIP tag, this is going to take a while |
Pablete1234
force-pushed
the
localdms
branch
2 times, most recently
from
50eeaa5
to
686a4dd
Compare
Pablete1234
force-pushed
the
localdms
branch
4 times, most recently
from
1649172
to
db50c62
Compare
|
I would like to call testers, this should have the main funcionallity implemented, but i'm sure this will have bugs, so plase test this and tell me your results |
Pablete1234
force-pushed
the
localdms
branch
from
db50c62
to
b0af847
Compare
Pablete1234
force-pushed
the
master
branch
2 times, most recently
from
27fe706
to
6d95d9c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NOTE]
I'll finnish this when #892 is merged, because #892 may have to change how all of this works
fixes #833
Has some bugs atm, needs testing
Bugs:
/kill shows DEATH_VOID instead of DEATH_SUICIDE
Death causes that show default message (i think this is because killer is not null, it's a entity that's not a player):
/summon PrimedTnt (or dispenser) (DEATH_EXPLOSION)
Falling anvil (DEATH_FALLING_BLOCK)
/summon Potion (or dispenser) (DEATH_POTION)
/summon Arrow (or dispenser) (DEATH_PROJECTILE)
/summon Arrow (or dispenser) knocks a player
Death causes i can't test:
LightningBolt (DEATH_LIGHTNING) (/summon LightingBolt doesn't work (sportbukkit?))
Starvation (DEATH_STARVATION) (having 0 hunger doesn't remove health)