Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovatebot: add automerge presets #2

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

kang-makes
Copy link
Member

@kang-makes kang-makes commented Sep 7, 2023

These are the first set of presets that might cover almost all our use cases.

@kang-makes kang-makes marked this pull request as draft September 7, 2023 20:14
@kang-makes kang-makes force-pushed the renovatebot/add-automerge-presets branch from 4e3086c to 74c362d Compare September 8, 2023 19:25
@kang-makes kang-makes marked this pull request as ready for review September 8, 2023 19:34
@kang-makes kang-makes force-pushed the renovatebot/add-automerge-presets branch from 74c362d to b8e6023 Compare September 8, 2023 19:52
@kang-makes kang-makes force-pushed the renovatebot/add-automerge-presets branch from b8e6023 to f1d455e Compare September 8, 2023 19:54
Copy link
Member

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, I might suggest shortening the names a bit:

  • automerge-all
  • automerge-minor
  • automerge-patch
  • automerge-docker-all
  • automerge-docker-digest
  • automerge-docker-minor
  • automerge-docker-patch
  • automerge-workflows-all

Also, newlines 😈

Comment on lines 15 to 19
{
"automerge": true,
"automergeType": "branch",
"pruneBranchAfterAutomerge": true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that this won't work without at least one test passing on the CI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Do you have any suggestion about what should I test?

There is nothing I can think of and I was going to add an empty workflow that simply exit 0 🤔

@kang-makes kang-makes merged commit 142529b into main Sep 11, 2023
1 check passed
@kang-makes kang-makes deleted the renovatebot/add-automerge-presets branch September 11, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants