-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renovatebot: add automerge presets #2
Conversation
4e3086c
to
74c362d
Compare
74c362d
to
b8e6023
Compare
b8e6023
to
f1d455e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall, I might suggest shortening the names a bit:
automerge-all
automerge-minor
automerge-patch
automerge-docker-all
automerge-docker-digest
automerge-docker-minor
automerge-docker-patch
automerge-workflows-all
Also, newlines 😈
{ | ||
"automerge": true, | ||
"automergeType": "branch", | ||
"pruneBranchAfterAutomerge": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that this won't work without at least one test passing on the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Do you have any suggestion about what should I test?
There is nothing I can think of and I was going to add an empty workflow that simply exit 0
🤔
These are the first set of presets that might cover almost all our use cases.