Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flameshot script to be universal #135

Merged
merged 13 commits into from
Oct 14, 2023
Merged

Conversation

NotAShelf
Copy link
Contributor

@NotAShelf NotAShelf commented May 13, 2022

  • wayland support
  • experimental local screenshots if domain & key are left empty

Checklist

  • I have read the Contributing Guidelines
  • I acknowledge that any submitted code will be licensed under the ISC License
  • I confirm that submitted code is my own work (partially)
  • I have tested the code, and confirm that it works

Enviroment

  • Operating System: NixOS 6.5.5-xanmod1
  • Tested On: only NixOS

Description

The script now supports Wayland through the help of Wayland native tools (such as grim and slurp) instead of attempting to get Flameshot to work on Sway and other wl-roots based compositors.

Additionally, it fixes a possible bug that went unnoticed with the if [[ -f $FILE ]] condition check.

Lastly, support for local screenshots are added and any screenshot taken with the script while KEY and DOMAIN values are null will be copied to the clipboard directly instead of throwing an error and exiting the script.

tl;dr:

  • wayland support
  • error turned into feature (local screenshots)
  • bug fix
  • logic and syntax improvements
  • script is now more verbose

Dependencies: (Wayland)

- wayland support
- experimental local screenshots if domain & key are left empty
@NotAShelf NotAShelf changed the title update flameshot script to be global update flameshot script to be universal May 13, 2022
@NotAShelf NotAShelf marked this pull request as ready for review May 13, 2022 04:50
@samip5
Copy link

samip5 commented Nov 20, 2022

I have been using this pretty much daily and works great. Thank you. :)

@tycrek tycrek added this to the 0.15.0 milestone Oct 14, 2023
@tycrek
Copy link
Owner

tycrek commented Oct 14, 2023

I'll aim to merge this with ass 0.15.0 and the universal script that exists on that branch.

@NotAShelf
Copy link
Contributor Author

I'll aim to merge this with ass 0.15.0 and the universal script that exists on that branch.

I'll do some tweaking to the script, please do give me a headsup before merging

@NotAShelf NotAShelf changed the base branch from master to dev/0.15.0 October 14, 2023 15:49
@NotAShelf
Copy link
Contributor Author

should be ready now

Copy link
Owner

@tycrek tycrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome; I'll merge in for now and combine it with the flameshot-v2.sh script at some point.

@tycrek tycrek merged commit e7213f2 into tycrek:dev/0.15.0 Oct 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants