Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize docker image and update package #244

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

Gauvino
Copy link
Contributor

@Gauvino Gauvino commented Oct 26, 2023

Checklist

  • I have read the Contributing Guidelines
  • I acknowledge that any submitted code will be licensed under the ISC License
  • I confirm that submitted code is my own work
  • I have tested the code, and confirm that it works

Enviroment

  • Operating System: WIN11 - Docker Desktop: v24.0.6
  • Node version: 20.9.0
  • npm version: 10.2.1

Description

This PR update the repository to nodejs 20.9, npm 10.2.1 and all the sub package, adds .dockerignore file to remove form the built image the useless file and changed the node based image to alpine for having a really lightweight image and efficient one reducing the size overall by almost 1Gb (as you can see in the screenshot below)

(Don't forget to edit the descripition of the [dev/0.15.0] PR)

Tested the image on Docker Desktop (v24.0.6) on Windows (11) and on Ubuntu 23.10 (Mantic) (v24.0.6)

chrome_EdrkeE4K1E
chrome_t1csmbUX7Y
chrome_prRiz5bugT

Superseded: #246

@tycrek tycrek added the merge conflict Automatically applied to PR's with merge conflicts label Oct 26, 2023
@tycrek
Copy link
Owner

tycrek commented Oct 26, 2023

[AUTOMATED MESSAGE] 🔴 This Pull Request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@tycrek tycrek removed the merge conflict Automatically applied to PR's with merge conflicts label Oct 26, 2023
@tycrek
Copy link
Owner

tycrek commented Oct 26, 2023

[AUTOMATED MESSAGE] 🟢 Conflicts have been resolved.

@tycrek tycrek added the merge conflict Automatically applied to PR's with merge conflicts label Oct 27, 2023
@tycrek
Copy link
Owner

tycrek commented Oct 27, 2023

[AUTOMATED MESSAGE] 🔴 This Pull Request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@tycrek
Copy link
Owner

tycrek commented Oct 27, 2023

[AUTOMATED MESSAGE] 🟢 Conflicts have been resolved.

@tycrek tycrek removed the merge conflict Automatically applied to PR's with merge conflicts label Oct 27, 2023
@Gauvino
Copy link
Contributor Author

Gauvino commented Oct 27, 2023

Go look on discord before merging ! @tycrek

package-lock.json Outdated Show resolved Hide resolved
@tycrek tycrek merged commit 2fc1ddf into tycrek:dev/0.15.0 Oct 27, 2023
2 checks passed
@Gauvino Gauvino deleted the patch/docker branch October 27, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants