Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for postgresql #245

Merged
merged 23 commits into from
Nov 2, 2023
Merged

add support for postgresql #245

merged 23 commits into from
Nov 2, 2023

Conversation

XWasHere
Copy link

Checklist

  • I have read the Contributing Guidelines
  • I acknowledge that any submitted code will be licensed under the ISC License
  • I confirm that submitted code is my own work
  • I have tested the code, and confirm that it works

Enviroment

  • Operating System: artix linux [Linux 6.5.5-arch1-1-custom x86_64]
  • Node version: 20.8.0
  • npm version: 10.1.0

Description

adds support for postgresql to ass and renames sql to database in userconfig. :3

@Gauvino
Copy link
Contributor

Gauvino commented Oct 26, 2023

Thanks you so much for all your work, you are really helping community right now for the 0.15 version!

@XWasHere
Copy link
Author

Thanks you so much for all your work, you are really helping community right now for the 0.15 version!

aaa thank you >w<
this is my first time contributing to a decently sized project so i have no idea what im doing, im really happy i can help somehow

@Gauvino
Copy link
Contributor

Gauvino commented Oct 26, 2023

Thanks you so much for all your work, you are really helping community right now for the 0.15 version!

aaa thank you >w<

this is my first time contributing to a decently sized project so i have no idea what im doing, im really happy i can help somehow

You're doing a really great job for now so keep it like this and my two im doing my best to help the project as best as I can

@Gauvino
Copy link
Contributor

Gauvino commented Oct 27, 2023

@XWasHere are you planning to add like mariadb or mongo db after ? or does it already support maria ?

@tycrek tycrek added the merge conflict Automatically applied to PR's with merge conflicts label Oct 27, 2023
@tycrek
Copy link
Owner

tycrek commented Oct 27, 2023

[AUTOMATED MESSAGE] 🔴 This Pull Request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@tycrek tycrek removed the merge conflict Automatically applied to PR's with merge conflicts label Oct 28, 2023
@tycrek
Copy link
Owner

tycrek commented Oct 28, 2023

[AUTOMATED MESSAGE] 🟢 Conflicts have been resolved.

@XWasHere
Copy link
Author

@XWasHere are you planning to add like mariadb or mongo db after ? or does it already support maria ?

i'll likely add support for other db's soon, i just started with postgres since its what i was most familiar with

@Gauvino
Copy link
Contributor

Gauvino commented Oct 28, 2023

@XWasHere are you planning to add like mariadb or mongo db after ? or does it already support maria ?

i'll likely add support for other db's soon, i just started with postgres since its what i was most familiar with

And probably the best

@tycrek tycrek added the enhancement New feature or request label Oct 30, 2023
@tycrek tycrek self-assigned this Oct 30, 2023
@tycrek tycrek merged commit 347b80e into tycrek:dev/0.15.0 Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants