Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Date & Big integer encoders #748

Merged
merged 4 commits into from
Sep 9, 2023

Conversation

cchantep
Copy link
Collaborator

@cchantep cchantep commented Sep 9, 2023

  • Add TypedEncoder instances for T <: java.util.Date (aka Data, sql.Data and sql.Timestamp, often used with Spark data types).
  • Add TypedEncoder instances for Scala & Java big integer

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 96.85% and project coverage change: -0.10% ⚠️

Comparison is base (180eaf6) 95.56% compared to head (8c0489c) 95.46%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   95.56%   95.46%   -0.10%     
==========================================
  Files          67       67              
  Lines        1172     1214      +42     
  Branches       44       41       -3     
==========================================
+ Hits         1120     1159      +39     
- Misses         52       55       +3     
Flag Coverage Δ
2.12-root-spark32 95.46% <96.85%> (-0.10%) ⬇️
2.12-root-spark33 95.46% <96.85%> (-0.10%) ⬇️
2.12-root-spark34 95.46% <96.85%> (-0.10%) ⬇️
2.13-root-spark34 96.16% <98.40%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ataset/src/main/scala/frameless/TypedEncoder.scala 96.72% <96.85%> (-0.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Once CI is 🟢 lets merge it!

@cchantep cchantep merged commit ca90137 into typelevel:master Sep 9, 2023
9 of 10 checks passed
@cchantep cchantep deleted the feature/more-encoders branch September 9, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants