Optimize ecovec![] macro
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurmaedje
reviewed
Aug 3, 2023
|
Originally, I planned to make a release today so that |
LLVM is not smart enough to eliminate calls to `EcoVec::reserve()` even when they are unecessary thanks to earlier calls to `EcoVec::reserve()` or `EcoVec::with_capacity()`. This patch elimates them when the `ecovec![]` macro is used. There may be other unnecessary calls which can be elimated in future patches. `ecovec![1, 2, 3]` results in 3 unecessary calls to `EcoVec::reserve()`. Fixed by forwarding to the `From<[T; N]>` impl. `ecovec![1; 42]` results in 42 unecessary calls to `EcoVec::reserve()`. Fixed by adding `EcoVec::push_unchecked()` function for when we know resizing is unnecessary.
Kmeakin
force-pushed
the
optimize-ecovec-macro
branch
from
fccdb38
to
46537aa
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM is not smart enough to eliminate calls to
EcoVec::reserve()even when they are unecessary thanks to earlier calls toEcoVec::reserve()orEcoVec::with_capacity(). This patch elimates them when theecovec![]macro is used. There may be other unnecessary calls which can be elimated in future patches.ecovec![1, 2, 3]results in 3 unecessary calls toEcoVec::reserve(). Fixed by forwarding to theFrom<[T; N]>impl.ecovec![1; 42]results in 42 unecessary calls toEcoVec::reserve(). Fixed by addingEcoVec::push_unchecked()function for when we know resizing is unnecessary.