This repository has been archived by the owner on Jan 22, 2022. It is now read-only.
Fix favicon in tab chromes #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save icon URL of tabs without QtWebEngine's favicon scheme and host
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save icon URL of tabs without QtWebEngine's favicon scheme and host
This should fix #456
This basically just removes
image://favicon/from the saved icon URL of tabs since favicons inQtWebEnginedoesn't seem to be cached and reusable after closing the app.Note: I'm not sure if this worked before and just a regression so it's possible that the proper fix is to re-enable caching of favicons on
QtWebEngineor something. I just don't know how or where that is. I tried to look for it 😅 .