Sky130 - Convert to Pydantic, support sky130_scl #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayiri-k
approved these changes
Mar 9, 2024
| @@ -53,4 +53,6 @@ def get_headers(source: str) -> List[str]: | |||
| # TODO: handle other compressed file types? Tools only seem to support gzip. | |||
| fd = os.open(source, os.O_RDONLY) | |||
| lines = os.pread(fd, nbytes, 0).splitlines() | |||
| return list(map(lambda l: l.decode('ascii', errors='ignore'), lines)) | |||
| lines = list(map(lambda l: l.decode('ascii', errors='ignore'), lines)) | |||
| all_lines = '\n'.join(lines).replace('\\\n','') # combine lines that are split by \ character | |||
There was a problem hiding this comment.
@harrisonliew This might be too hacky, but basically in one of the sky130 lib files (sky130_ef_io__gpiov2_pad_wrapped_ss_ss_100C_1v60_3v00.lib) the capacitive_load_unit declaration spanned 2 lines and it messed up the parsing in LIBUtils.get_cap_unit()
capacitive_load_unit(1.000000, \
"pf");
There was a problem hiding this comment.
I think that's valid. But maybe the better approach is to remove line continuations (\) before processing lines. Can you also fix the type checker error?
synthesis runs until genus breaks on trying to do clock gating with no latches- asking cadence folks on how to fix.
elamdf
reviewed
Mar 10, 2024
par fails (either in place_tap_cells or in power_straps if you force it past place_tap_cells with a removal hook due to no tapcells)
pwell/nwell/li1, clk gating cell disabled?)
|
syn/par works on commercial tutorial flow |
|
|
…ps hook since we don't have tapcells to reference for rails. This is lvs clean for the sky130-commercial-tutorial (but there are no srams? unsure why)
pegasus work. drc has like 15 random enclousure violations.. not sure why, they don't seem to be systemic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen_configfor tech plugins to override and generate their own config (TechJSONinstance, i.e. directly creating the Pydantic model). This enables multi-library support within the same tech plugin.sky130.tech.jsonLEFUtils(unfortunately can't create Metal object directly or else it has a circular import)gds_map_filereading in OpenROAD pluginTODOs:
Related PRs / Issues
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?poetry.lockfile if you updated the requirements inpyproject.toml?e2e/if this feature depends on updated plugins?