Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crank nicholson #36

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Crank nicholson #36

wants to merge 3 commits into from

Conversation

brmather
Copy link
Member

@brmather brmather commented Jul 8, 2020

Implement a Crank Nicholson scheme for the diffusion equation.

Uses the "theta rule":

  • theta=0 : forward Euler
  • theta=1: backward Euler
  • theta=0.5 : Crank Nicholson

@brmather brmather changed the base branch from master to dev July 8, 2020 08:05
@lmoresi
Copy link
Member

lmoresi commented Jul 9, 2020

Do we want this to pass the benchmarks before merging or have it as a placeholder and develop around it ?

@brmather
Copy link
Member Author

brmather commented Jul 9, 2020

It's not ready to merge, but I quite like having the PR open so we have one place to comment on stuff that doesn't work.

@brmather brmather marked this pull request as draft July 9, 2020 01:50
@brmather
Copy link
Member Author

brmather commented Jul 9, 2020

The problem I see with taking the line integral is that the natural neighbours are unordered. They were ordered anticlockwise when we obtained the triangulation from Qhull but that's quite time consuming to do here. There is probably a better way to go about it, but I've been chasing this white rabbit too long that I've entered the matrix. I'd appreciate if @lmoresi or @rbeucher could take a look.

Ex7b-LinearDiffusion.txt (uploaded as a txt file)

@lmoresi
Copy link
Member

lmoresi commented Jul 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants