Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22721 Update filtration_test for Python 3.13 #3046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yselkowitz
Copy link

@yselkowitz yselkowitz commented Jun 21, 2024

unittest.makeSuite() was deprecated in Python 3.11 and removed in 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#unittest

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22721
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

@echeran echeran changed the title Update filtration_test for Python 3.13 ICU-22721 Update filtration_test for Python 3.13 Jun 27, 2024
@echeran
Copy link
Contributor

echeran commented Jun 27, 2024

The change looks good, and thanks for making the change. I updated the PR with appropriate details.

The one last thing required is for the commit message to be prefixed with "ICU-22721" followed by a space. Can you do that? If not, one of us can. FWIW, the easiest way to achieve that is to use the PR Checker Bot. In the table of PR checks, in the row that says "jira-ticket", click the "Details" link. The opportunity to squash the one commit won't affect the code, and in this case won't affect the number of commits on the branch, but you can use it to reword the commit message.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@yselkowitz
Copy link
Author

@echeran should be fixed now, all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants